Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: chain/actors: add inspection methods to actor gen interface #9667

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

frrist
Copy link
Member

@frrist frrist commented Nov 16, 2022

  • adds the following methods to all generated actor interfaces:
    • Code() cid.Cid
    • ActorKey() string
    • ActorVersion() actorstypes.Version
    • AllCodes() []cid.Cid

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@frrist frrist requested a review from a team as a code owner November 16, 2022 22:36
@frrist frrist changed the title refactor: add inspection methods to actor gen interface refactor: chain/actors: add inspection methods to actor gen interface Nov 16, 2022
@frrist frrist self-assigned this Nov 16, 2022
@frrist frrist force-pushed the frrist/actor-gen-again branch from 8d9f9c5 to 4befc59 Compare November 16, 2022 22:59
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- feel free to either land here or move to go-state-types.

Note that moving to go-state-types will lose some of the functionality (eg. Codes), since the manifests live in Lotus.

@frrist
Copy link
Member Author

frrist commented Nov 17, 2022

Let's leave it here, then, until a clear migration strategy to go-state-types is created. Losing the Codes method is a deal breaker since that was the reason for this PR.
I assume you'll merge this when ready (please squash when you do)? Or should I hit the button?

- adds the following methods to all generated actor interfaces:
  - Code() cid.Cid
  - ActorKey() string
  - ActorVersion() actorstypes.Version
  - AllCodes() []cid.Cid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants